This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch

From: Alan Modra <amodra at bigpond dot net dot au>
To: Carlos O'Donell <carlos at baldric dot uwo dot ca>
Cc: "H. J. Lu" <hjl at lucon dot org>, libc-alpha at sources dot redhat dot com, debian-glibc at lists dot debian dot org
Date: Thu, 26 Sep 2002 09:07:55 +0930
Subject: Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
References: <20020925170306.GB14672@systemhalted> <20020925100553.A14081@lucon.org> <20020925173246.GA15399@systemhalted>

On Wed, Sep 25, 2002 at 01:32:46PM -0400, Carlos O'Donell wrote:
> > > +#define DO_ELF_MACHINE_REL_RELATIVE(map, l_addr, reloc)			\
> > > +  elf_machine_rel_relative (l_addr, reloc,				\
> > > +			    (void *) (l_addr + relative->r_offset))
>                                                ^^^^^^^^
>                                                reloc

Oops.  Yes, this needs fixing.

[snip]
> 	The fact that it doesn't have detremental effects
> 	is rather disconcerting.

Not really.  This macro is only used in one place, and "relative" is
in scope where the macro is expanded.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

References:
- [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
  - From: Carlos O'Donell
- Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
  - From: H. J. Lu
- Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]