This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] bug-regex12 testcase
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Isamu Hasegawa <isamu at yamato dot ibm dot com>
- Cc: Ulrich Drepper <drepper at redhat dot com>, Jack Howarth <howarth at bromo dot med dot uc dot edu>, libc-alpha at sources dot redhat dot com
- Date: Sat, 28 Sep 2002 21:57:23 +0200
- Subject: [PATCH] bug-regex12 testcase
- References: <20020911181008.Q1013@sunsite.ms.mff.cuni.cz> <ubs6jxxbq.wl@AMBER.yamato.ibm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Sep 28, 2002 at 12:32:25AM +0900, Isamu Hasegawa wrote:
> I prepared a patch to fix the problem.
>
> The problem was that there are some defects in the evaluations of back
> references. And I needed to restructure these evaluations.
> (I'm sorry for such a big patch.)
>
> However, it might not be a sufficient patch, since dc.sed of sed-3.02
> seems to fall infinite loop.
> On the other hand, perhaps it might not be a bug, because the infinite
> loop of dc.sed seems not to be in regex but in the dc.sed script, and
> the behavior of regex was a bit changed from old regex.
> (e.g. Executing the following command returns the result "NG".
> $ echo aa | sed 's/\(a\+\)\{3\}/NG/'
> However, "\(a\+\)\{3\}" shouldn't match with "aa", should it?
> We fix these some dubious behaviors, and it might prevent dc.se
> from desirable behavior.)
>
> Then if you see other problems, please let me know.
Thanks. Unfortunately this patch breaks something else (attached
bug-regex12.c). This is distilled from dc.sed as the first reg*exec
call with different return value between sed's builtin regex and glibc
regex.
bug-regex12.c doesn't match (ie. succeeds) with glibc 2.2.5 and IMHO
that's correct.
"^<\\([^~]*\\)\\([^~]\\)[^~]*~\\1\\(.\\).*|=.*\\3.*\\2"
"<,.8~2,~so-|=-~.0,123456789<><"
\1 must match "", since the prefix after first ~ differs
from prefix after first <. Thus \2 must be "," and \3 must be "2".
After "|=" "2" can be found but there is no "," after that.
2002-09-28 Jakub Jelinek <jakub@redhat.com>
* posix/bug-regex11.c (tests): Add flags field.
(main): Avoid warnings. Use test[i].flags. Return nonzero
if any of the tests failed.
* posix/bug-regex12.c: New test.
* posix/Makefile (tests): Add bug-regex12.
--- libc/posix/bug-regex11.c.jj 2002-09-12 08:47:07.000000000 +0200
+++ libc/posix/bug-regex11.c 2002-09-28 21:39:18.000000000 +0200
@@ -24,19 +24,20 @@
#include <stdio.h>
#include <stdlib.h>
+/* Tests supposed to match. */
struct
{
const char *pattern;
const char *string;
- int nmatch;
+ int flags, nmatch;
regmatch_t rm[4];
} tests[] = {
/* Test for newline handling in regex. */
- { "[^~]*~", "\nx~y", 2, { { 0, 3 }, { -1, -1 } } },
+ { "[^~]*~", "\nx~y", 0, 2, { { 0, 3 }, { -1, -1 } } },
/* Other tests. */
- { ".*|\\([KIO]\\)\\([^|]*\\).*|?[KIO]", "10~.~|P|K0|I10|O16|?KSb", 3,
+ { ".*|\\([KIO]\\)\\([^|]*\\).*|?[KIO]", "10~.~|P|K0|I10|O16|?KSb", 0, 3,
{ { 0, 21 }, { 15, 16 }, { 16, 18 } } },
- { ".*|\\([KIO]\\)\\([^|]*\\).*|?\\1", "10~.~|P|K0|I10|O16|?KSb", 3,
+ { ".*|\\([KIO]\\)\\([^|]*\\).*|?\\1", "10~.~|P|K0|I10|O16|?KSb", 0, 3,
{ { 0, 21 }, { 8, 9 }, { 9, 10 } } }
};
@@ -45,13 +46,14 @@ main (void)
{
regex_t re;
regmatch_t rm[4];
- int n, i, ret = 0;
+ size_t i;
+ int n, ret = 0;
mtrace ();
for (i = 0; i < sizeof (tests) / sizeof (tests[0]); ++i)
{
- n = regcomp (&re, tests[i].pattern, 0);
+ n = regcomp (&re, tests[i].pattern, tests[i].flags);
if (n != 0)
{
char buf[500];
@@ -84,5 +86,5 @@ main (void)
regfree (&re);
}
- return 0;
+ return ret;
}
--- libc/posix/bug-regex12.c.jj 2002-09-28 21:48:39.000000000 +0200
+++ libc/posix/bug-regex12.c 2002-09-28 21:39:28.000000000 +0200
@@ -0,0 +1,71 @@
+/* Regular expression tests.
+ Copyright (C) 2002 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+ Contributed by Jakub Jelinek <jakub@redhat.com>, 2002.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, write to the Free
+ Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+ 02111-1307 USA. */
+
+#include <sys/types.h>
+#include <mcheck.h>
+#include <regex.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+/* Tests supposed to not match. */
+struct
+{
+ const char *pattern;
+ const char *string;
+ int flags, nmatch;
+} tests[] = {
+ { "^<\\([^~]*\\)\\([^~]\\)[^~]*~\\1\\(.\\).*|=.*\\3.*\\2",
+ "<,.8~2,~so-|=-~.0,123456789<><", REG_NOSUB, 0, }
+};
+
+int
+main (void)
+{
+ regex_t re;
+ regmatch_t rm[4];
+ size_t i;
+ int n, ret = 0;
+
+ mtrace ();
+
+ for (i = 0; i < sizeof (tests) / sizeof (tests[0]); ++i)
+ {
+ n = regcomp (&re, tests[i].pattern, tests[i].flags);
+ if (n != 0)
+ {
+ char buf[500];
+ regerror (n, &re, buf, sizeof (buf));
+ printf ("regcomp %d failed: %s\n", i, buf);
+ ret = 1;
+ continue;
+ }
+
+ if (! regexec (&re, tests[i].string, tests[i].nmatch,
+ tests[i].nmatch ? rm : NULL, 0))
+ {
+ printf ("regexec %d incorrectly matched\n", i);
+ ret = 1;
+ }
+
+ regfree (&re);
+ }
+
+ return ret;
+}
--- libc/posix/Makefile.jj 2002-09-05 09:38:17.000000000 +0200
+++ libc/posix/Makefile 2002-09-28 21:49:04.000000000 +0200
@@ -72,7 +72,7 @@ tests := tstgetopt testfnm runtests run
tst-truncate64 tst-fork tst-fnmatch tst-regexloc tst-dir \
tst-chmod bug-regex1 bug-regex2 bug-regex3 bug-regex4 \
tst-gnuglob tst-regex bug-regex5 bug-regex6 bug-regex7 \
- bug-regex8 bug-regex9 bug-regex10 bug-regex11
+ bug-regex8 bug-regex9 bug-regex10 bug-regex11 bug-regex12
ifeq (yes,$(build-shared))
test-srcs := globtest
tests += wordexp-test tst-exec tst-spawn
Jakub