This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Centralize divdi3.c handling on 32-bit platforms


> 1) We are still dragging along a dead file for divdi3.c in powerpc32, no?
> 
> libc/sysdeps/powerpc/powerpc32/divdi3.c

It's not "dead" now, in that it's what's being used on powerpc..

> 2) Also, in comparision to Franz's proposed patch, why don't we have
> any of the versioning he was doing with...
> 
> +CPPFLAGS-divdi3.c += -DDIVDI3_DEFAULT_VERSION=GLIBC_2.0 \
> +                    -DDIVDI3_COMPAT_INTRODUCED=GLIBC_2_0 \
> +                    -DDIVDI3_COMPAT_OBSOLETED=GLIBC_2_2_6

That stuff would be reasonable to add, though it only affects platforms
whose first version is GLIBC_2.2.6 or later.  However, to be correct it
needs to be done with the compat_symbol macro.  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]