This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: getifaddrs


> Functions ``__ifreq'' and ``getifaddrs'' were changed to support
> ``struct sockaddr'' structures of arbitrary size.
> 
> The fields ``ifa_netmask'' and ``ifa_broadaddr'' are set to NULL, if
> the coresponding ``ioctl'' fails, per BSD manual pages.

For future contributions, please put your remarks about what changed into
the form of ChangeLog entries in the canonical format.

> On NetBSD these ioctls fail for the large number of down interfaces,
> as a result no information can be obtained for up interfaces.

Remarks such as these should go into comments in the code rather than into
log entries.

You must refrain from random reformatting of comments and code when you
send patches.  It makes your changes much more difficult to review quickly.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]