This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RE_ENABLE_I18N in regex_internal.h


> Also, Paolo's regcomp patch is needed too (and it is right for
> libc too, since regex.c has at the top:

What about the other part (removing __ in front of __wcrtomb)?

Also, I got reports that on HP/UX and other systems it does not compile
because a few MBCS functions are unavailable.  Is this part of the patch ok

> diff -rNU3 isamu/regex.c mine/regex.c
> --- isamu/regex.c Fri Nov 22 12:04:37 2002
> +++ mine/regex.c Fri Nov 22 12:04:31 2002
> @@ -41,6 +41,14 @@
>  #  define re_compile_fastmap(bufp) __re_compile_fastmap (bufp)
>  #endif
>
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
> +#if (HAVE_WCTYPE_H && HAVE_WCHAR_H) || _LIBC
> +#define RE_ENABLE_I18N
> +#endif
> +

Possibly adding more cases to the #if?

And finally...

>  #if _LIBC || __GNUC__ >= 3
>  # define BE(expr, val) __builtin_expect (expr, val)
>  #else

...isn't that _LIBC not needed?

Paolo




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]