This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: stat.h with nanosecond resolution


Hi Andreas,
> - s390x: The s390-64/kernel_stat.h file differed from the one in Linux
> 2.5.  I've merged in the 2.5 version now (it has the same layout as
> the 2.4 version).  Martin, please double check that this change is
> correct, I don't see how it could have worked before.

You are correct, the kernel_stat definition for s390x is broken. It does
work despite it because the structure isn't used anywhere in glibc for
s390x. It tested this by removing kernel_stat.h and a make, make check
of todays libc snapshot. Your corrected version isn't perfect either,
st_dev, st_ino, st_rdev are "unsigned long" not "unsigned int" and
st_nlink/st_mode have swapped places. Two choices: remove kernel_stat.h
or fix it a second time. I would remove the file. Whats your preference?

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]