This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: mips64 n32/n64 new files
- From: Andreas Jaeger <aj at suse dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Sat, 15 Mar 2003 07:23:40 +0100
- Subject: Re: mips64 n32/n64 new files
- References: <or4r667zuy.fsf@free.redhat.lsd.ic.unicamp.br>
Alexandre Oliva <aoliva at redhat dot com> writes:
> Index: sysdeps/unix/sysv/linux/mips/mips64/recv.c
> --- /dev/null 2002-10-04 15:48:04.000000000 -0300
> +++ sysdeps/unix/sysv/linux/mips/mips64/recv.c 2003-01-15 12:28:59.000000000 -0200
> @@ -0,0 +1,34 @@
> +/* Copyright (C) 2001, 2003 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, write to the Free
> + Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> + 02111-1307 USA. */
> +
> +#include <errno.h>
> +#include <sys/socket.h>
> +#include <sysdep.h>
> +
> +/* Read N bytes into BUF from socket FD.
> + Returns the number read or -1 for errors. */
> +
> +ssize_t
> +__libc_recv (int fd, void *buf, size_t n, int flags)
> +{
> +
> + return INLINE_SYSCALL (recvfrom, 6, fd, buf, n, flags, NULL, NULL);
> +}
> +
> +weak_alias (__libc_recv, __recv)
> +weak_alias (__recv, recv)
This is wrong.
You do not implement cancelable syscalls. And please avoid
duplication of files. I think this can be just:
#include <sysdeps/unix/sysv/linux/x86_64/recv.c>
The same applies to the other socket functions.
The rest is ok,
Andreas
--
Andreas Jaeger
SuSE Labs aj at suse dot de
private aj at arthur dot inka dot de
http://www.suse.de/~aj