This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tst-nice.c


On Tue, Mar 18, 2003 at 05:27:42PM -0800, Roland McGrath wrote:
> We are most certainly interested in adding more regression tests.
> Thanks very much for taking the time to use the test-skeleton.c form properly.
> 
> Your test will break if the test run itself is nice'd.  It is simple enough
> to make it robust by calling nice (0) first to find the original nice value
> before you increment it, and then calculate the expected result using that.

Here is the corrected code.  I tested it with both positively and negatively
nice'd 'make check'.  Thanks.


2003-03-19  Amos Waterland  <apw at us dot ibm dot com>

        * posix/tst-nice.c: New file.
        * posix/Makefile (tests): Add tst-nice.

--- /dev/null	2002-08-30 18:31:37.000000000 -0500
+++ posix/tst-nice.c	2003-03-19 11:17:51.000000000 -0600
@@ -0,0 +1,67 @@
+/* Copyright (C) 2001 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, write to the Free
+   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+   02111-1307 USA.  */
+
+#include <errno.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#define TEST_FUNCTION do_test ()
+static int
+do_test (void)
+{
+  int result = 0;
+
+  /* Test that nice() does not incorrectly return 0.  */
+  {
+    int ret, expected;
+    const int incr = 10;
+
+    /* Discover current nice value.  */
+    errno = 0;
+    ret = nice (0);
+    if (ret == -1 && errno != 0)
+      {
+	printf ("break: nice(%d) return: %d, errno: %d\n", 0, ret, errno);
+	return 1;
+      }
+    expected = ret + incr;
+
+    /* Nice ourselves up.  */
+    errno = 0;
+    ret = nice (incr);
+    if (ret == -1 && errno != 0)
+      {
+	printf ("break: nice(%d) return: %d, errno: %d\n", incr, ret, errno);
+	return 1;
+      }
+
+    /* Check for return value being zero when it shouldn't.  Cannot simply
+       check for expected value since nice values are capped at 2^n-1.  */
+    if (ret == 0 && ret != expected)
+      {
+	printf ("fail: retval (%d) of nice(%d) != %d\n", ret, incr, expected);
+	++result;
+      }
+
+    printf ("pass: nice(%d) return: %d\n", incr, ret);
+  }
+
+  return result;
+}
+
+#include "../test-skeleton.c"
--- posix/Makefile.old	2003-03-19 11:17:11.000000000 -0600
+++ posix/Makefile	2003-03-19 11:17:31.000000000 -0600
@@ -75,7 +75,7 @@
 		   tst-chmod bug-regex1 bug-regex2 bug-regex3 bug-regex4 \
 		   tst-gnuglob tst-regex bug-regex5 bug-regex6 bug-regex7 \
 		   bug-regex8 bug-regex9 bug-regex10 bug-regex11 bug-regex12 \
-		   bug-regex13 bug-regex14 bug-regex15 bug-regex16
+		   bug-regex13 bug-regex14 bug-regex15 bug-regex16 tst-nice
 ifeq (yes,$(build-shared))
 test-srcs	:= globtest
 tests           += wordexp-test tst-exec tst-spawn


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]