Re: p{read,write}{,64} mips n64 changes

[Alexandre Oliva <aoliva at redhat dot com>]

On Mar 20, 2003, Andreas Jaeger <aj at suse dot de> wrote:

> I see - but I would nevertheless suggest something different

Then please make your suggestion more explicit.  I still can't tell
what you're looking for.  We pass arguments in different forms to
__LONG_LONG_PAIR in the off64_t and off_t versions of the pread and
pwrite functions, making a single-argument macro unsuitable.  We have
to tweak the prototypes of the syscalls anyway.  A 3-argument macro,
with one argument used on n64, and the other two passed to
__LONG_LONG_PAIR on n32, to be defined in say sysdep.h is a
possibility, but I find this extremely ugly.

Yet another possibility is to always extend the off_t value to
off64_t, which would render the single-macro approach possible, yet
with a small performance penalty.  It still leaves us with the problem
of adjusting the prototypes.  I don't see any beautiful solution.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva at {redhat dot com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva at {lsd dot ic dot unicamp dot br, gnu.org}
Free Software Evangelist                Professional serial bug killer