This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: make existing mips files multi-ABI


Alexandre Oliva <aoliva at redhat dot com> writes:

> +/* As tempting as it is to define this, the userland data structures
> +   are not identical, because of different padding.  Perhaps they
> +   should be?  */
> +/* # define XSTAT_IS_XSTAT64 1 */

Please remove that comment and the last sentence of the define.

> +#endif
> +/* Definition of `struct stat' used in the kernel.  */
> +#if _MIPS_SIM != _MIPS_SIM_ABI32
>  struct kernel_stat
>    {
>      unsigned int st_dev;
>      unsigned int __pad1[3];
> -    unsigned long st_ino;
> +    __extension__ unsigned long long st_ino;

We don't need extension here, this file is internal to glibc.

>      unsigned int st_mode;
>      unsigned int st_nlink;
>      int st_uid;
>      int st_gid;
>      unsigned int st_rdev;
>      unsigned int __pad2[3];
> -    long st_size;
> +    __extension__ long long st_size;
>      unsigned int st_atime;
>      unsigned int __unused1;
>      unsigned int st_mtime;
> @@ -20,7 +26,7 @@ struct kernel_stat
>      unsigned int __unused3;
>      unsigned int st_blksize;
>      unsigned int __pad3;
> -    unsigned long st_blocks;
> +    __extension__ unsigned long long st_blocks;
>    };
>  #else
>  struct kernel_stat

Ok, with these changes,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj at suse dot de
   private aj at arthur dot inka dot de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]