This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix utimes (was Re: utimes())

From: Greg Schafer <gschafer at zip dot com dot au>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: libc-alpha at sources dot redhat dot com
Date: Thu, 31 Jul 2003 23:43:06 +1000
Subject: Re: [PATCH] Fix utimes (was Re: utimes())
References: <20030731122612.GA620@tigers-lfs.nsw.bigpond.net.au> <20030731124735.GD20507@sunsite.ms.mff.cuni.cz>

On Thu, Jul 31, 2003 at 02:47:35PM +0200, Jakub Jelinek wrote:
> The testcase is wrong, you are passing 3 uninitialized values to utimes.
> But sysdeps/unix/sysv/linux/utimes.c is wrong as well, it will set
> actime and modtime to either 1 (unless tvp[0].tv_sec+tv_usec is very low).
> 
> 2003-07-31  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* sysdeps/unix/sysv/linux/utimes.c (__utimes): Add parens so that
> 	actime and modtime are computed properly.

Thanks, that fixed it.

There is similar code in sysdeps/unix/sysv/linux/futimes.c and
sysdeps/posix/utimes.c that may also be affected.

Greg

References:
- utimes()
  - From: Greg Schafer
- [PATCH] Fix utimes (was Re: utimes())
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]