This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed-up character range regexes by up to 2x



+#ifdef RE_ENABLE_I18N
int icase = (dfa->mb_cur_max == 1 && (bufp->syntax & RE_ICASE));
+#else
+ int icase = (bufp->syntax & RE_ICASE);
+#endif


It may be that the correct patch is simply to use:

int icase = (dfa->mb_cur_max == 1 && (bufp->syntax & RE_ICASE));

with no surrounding #ifdef. If so, fine.


I might be missing something overly obvious, but I see 4 lines added by your patch exactly around the line you suggest, not just the #else branch.

Paolo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]