Re: NIS performance patches

[Jeff Bastian <jmbastia at ti dot com>]

> As I wrote to you yesterday, I hadn't the time to look at it yet.

Sorry, I didn't realize you were on the libc-alpha mailing list, so I 
was just looking for feedback on the other half of the patches.



> And this part is not ok. While the idea is correct, the implementation
> does the worst thing that could happen (in conjunction with your
> ypbind changes):
>
> If the cached data is invalid, we will now always ask ypbind for
> a new server and ypbind will query the server. This is overkill.
> If the cached data is invalid, we should at first try if the binding
> files are updated. And only if this fails, too, we should start
> searching a new server.

Hmm?  We only try to find a new server if an error was returned from 
clnt_call() and we're on the first iteration if the while() loop.

The test_bindings_once() function then calls do_broadcast() which calls 
either remove_bindingfile() or update_bindingfile() and the invalid data 
in the binding file will be cleaned up.

Maybe I'm not reading something right...?

Let me look at your patches.

Thanks,
Jeff