This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Revamp HUGE_VAL, INFINITY, NAN


Looks OK.  YOu can check it in.  Just one comment:

9:31:37 -0000
> @@ -31,14 +31,23 @@ __BEGIN_DECLS
>  /* Get machine-dependent HUGE_VAL value (returned on overflow).
>     On all IEEE754 machines, this is +Infinity.  */
>  #include <bits/huge_val.h>
> +#ifdef __USE_ISOC99
> +# include <bits/huge_valf.h>
> +# include <bits/huge_vall.h>
> +#endif
> +
> +/* Get machine-dependent INFINITY value.  */
> +#ifdef	 __USE_ISOC99
> +# include <bits/inf.h>
> +#endif
>  
>  /* Get machine-dependent NAN value (returned for some domain errors).  */
>  #ifdef	 __USE_ISOC99
>  # include <bits/nan.h>
>  #endif

No need for three #ifdef, one is enough.  We should not make the public
headers harder to parse than necessary.


-- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]