This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fwrite not 64-bit clean


Here's an updated patch, it fixes the problem indeed and incorporates
Andreas Schwab's observations of doing too much...

Ok to commit?

Andreas

2004-03-31  Andreas Jaeger  <aj@suse.de>

        * libio/fileops.c (new_do_write): Return _IO_size_t to make 64-bit
        clean.

============================================================
Index: libio/fileops.c
--- libio/fileops.c	14 Jan 2004 18:40:03 -0000	1.102
+++ libio/fileops.c	31 Mar 2004 09:08:46 -0000
@@ -472,7 +472,7 @@ _IO_file_setbuf_mmap (fp, p, len)
   return result;
 }
 
-static int new_do_write __P ((_IO_FILE *, const char *, _IO_size_t));
+static _IO_size_t new_do_write __P ((_IO_FILE *, const char *, _IO_size_t));
 
 /* Write TO_DO bytes from DATA to FP.
    Then mark FP as having empty buffers. */
@@ -489,7 +489,7 @@ _IO_new_do_write (fp, data, to_do)
 INTDEF2(_IO_new_do_write, _IO_do_write)
 
 static
-int
+_IO_size_t
 new_do_write (fp, data, to_do)
      _IO_FILE *fp;
      const char *data;

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]