This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: ffsl on s390x must fail
- From: Thorsten Kukuk <kukuk at suse dot de>
- To: libc-alpha at sources dot redhat dot com
- Date: Fri, 9 Apr 2004 16:21:11 +0200
- Subject: Re: ffsl on s390x must fail
- Organization: SuSE Linux AG, Nuernberg, Germany
- References: <20040409110249.GA4461@suse.de>
On Fri, Apr 09, Thorsten Kukuk wrote:
>
> Hi,
>
> test-ffs fails on s390x. No wonder because s390x uses the s390
> implementation, and int is not equal to long on s390x.
> But on s390x, ffsl is a weak alias to ffsll and to _ffs. And
> it seems the wrong weak alias wins.
Here is a fix for it:
2004-04-09 Thorsten Kukuk <kukuk@suse.de>
* sysdeps/s390/ffs.c: Don't add ffsl weak alias on s390x
--- sysdeps/s390/ffs.c 6 Jul 2001 04:56:02 -0000 1.4
+++ sysdeps/s390/ffs.c 9 Apr 2004 14:19:17 -0000
@@ -63,6 +63,8 @@
}
weak_alias (__ffs, ffs)
+#if ULONG_MAX == UINT_MAX
#undef ffsl
weak_alias (__ffs, ffsl)
+#endif
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Maxfeldstr. 5 D-90409 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B