This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
obstack.c defines a variable that isn't used
- From: Paul Eggert <eggert at CS dot UCLA dot EDU>
- To: libc-alpha at sources dot redhat dot com
- Date: Wed, 19 May 2004 16:27:29 -0700
- Subject: obstack.c defines a variable that isn't used
obstack.c defines a global variable _obstack that is not used, and
hasn't been used as far back as I can see. Any use of it must predate
CVS revision 1.1 of obstack.c and obstack.h (dated 1996). I did find
a copy of glibc 1.06.4 on the net (dated 1993) and it isn't used there
either. So it should be safe to remove it.
2004-05-19 Paul Eggert <eggert@cs.ucla.edu>
* malloc/obstack.c (_obstack): Remove unused variable.
It hasn't been used by glibc since at least 1.06.4 (dated 1993).
Index: lib/obstack.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/obstack.c,v
retrieving revision 1.25
diff -p -u -r1.25 obstack.c
--- lib/obstack.c 17 May 2004 07:52:52 -0000 1.25
+++ lib/obstack.c 19 May 2004 20:00:32 -0000
@@ -102,11 +102,6 @@ int obstack_exit_failure = EXIT_FAILURE;
# define obstack_exit_failure exit_failure
# endif
-/* The non-GNU-C macros copy the obstack into this global variable
- to avoid multiple evaluation. */
-
-struct obstack *_obstack;
-
/* Define a macro that either calls functions with the traditional malloc/free
calling interface, or calls functions with the mmalloc/mfree interface
(that adds an extra first argument), based on the state of use_extra_arg.