Re: [PATCH] long double IEEE double -> quad switch (take 2)

[Ulrich Drepper <drepper at redhat dot com>]

I few things I found so far:


~ I don't like the <math.h> change.  Why is it necessary to add this
nexttoward business here?


~ I think include/math.h should include math_ldbl_opt.h.  If necessary
create an empty version of the file.  This will remove a whole bunch of
the #includes you added (and in the new code).


+++ libc/sysdeps/ieee754/ldbl-opt/nldbl-obstack_vprintf.c
2004-07-06 15:38:13.000000000 -0400
@@ -0,0 +1,8 @@
+#include "nldbl-compat.h"
+
+int
+attribute_hidden
+obstack_vprintf (struct obstack *obstack, const char *fmt, va_list ap)
+{
+  return __nldbl_obstack_vprintf (obstack, fmt, ap);
+}

Why is the function hidden?  Couldn't this create some problems with gcc
which wants to perform some optimizations?  At least at a comment (and
copyright).  Copyrights are missing from some more new files with real
code in ldbl-opt/.


~ sysdeps/ieee754/ldbl-opt/Makefile: I wonder if LONG_DOUBLE_OPTIONAL
shouldn't be unconditionally be defined for all files instead of adding
it for each of the source files.  It's so easy to forget about adding
the line to the Makefile and the Makefile gets to ugly.


~ changes like those to libio/swscanf.c probably mean a few
libc_hidden_proto/def can be removed.









-- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â