Re: [PATCH] MIPS/Linux: Kernel vs libc struct siginfo discrepancy

[Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>]

Maciej W. Rozycki wrote:
> Hello,
> 
>  Since the following change:
> 
> http://www.linux-mips.org/cvsweb/linux/include/asm-mips/siginfo.h.diff?r1=1.4&r2=1.5&only_with_tag=MAIN
> 
> dated back to Aug 1999 (!), the definitions of struct siginfo in Linux and 
> GNU libc differ to each other.

Only 2.4 Kernels, 2.6 uses the normal definition again.

> While it's the kernel that is at fault by 
> changing its ABI, at this stage it may be more acceptable to update glibc 
> as it's not the only program interfacing to Linux (uClibc?).  It doesn't 
> seem to be a heavily used feature as otherwise someone else would have 
> noticed the problem during these five years.  As I don't really have a 
> preference, hereby I provide two patches to choose from and ask for 
> voting.

I prefer to bring the 2.4 kernel in line with the rest of the system.

> The ChangeLog entry is for glibc, of course.
> 
> 2004-11-10  Maciej W. Rozycki  <macro@linux-mips.org>
> 
> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h [struct siginfo] 
> 	(_sigchld): Update to match the kernel.
> 
>   Maciej
> 
> glibc-2.3.3-20041018-mips-siginfo_sigchld-1.patch
> diff -up --recursive --new-file glibc-2.3.3-20041018.macro/sysdeps/unix/sysv/linux/bits/siginfo.h glibc-2.3.3-20041018/sysdeps/unix/sysv/linux/bits/siginfo.h
> --- glibc-2.3.3-20041018.macro/sysdeps/unix/sysv/linux/bits/siginfo.h	Tue Apr 22 02:26:04 2003
> +++ glibc-2.3.3-20041018/sysdeps/unix/sysv/linux/bits/siginfo.h	Wed Nov 10 16:52:24 2004

You surely meant to change the mips-specific siginfo.h here.