This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: HEAD and gcc4 build fixes for MIPS
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Thu, 10 Feb 2005 14:42:50 +0000 (GMT)
- Subject: Re: HEAD and gcc4 build fixes for MIPS
- References: <20050209223704.GA15593@nevyn.them.org>
On Wed, 9 Feb 2005, Daniel Jacobowitz wrote:
> @@ -162,6 +164,24 @@ la_symbind64 (Elf64_Sym *sym, unsigned i
> # define La_regs La_ia64_regs
> # define La_retval La_ia64_retval
> # define int_retval lrv_r8
> +#elif defined __mips__ && _MIPS_SIM == _ABIO32
> +# define pltenter la_mips_o32_gnu_pltenter
> +# define pltexit la_mips_o32_gnu_pltexit
> +# define La_regs La_mips_32_regs
> +# define La_retval La_mips_32_retval
> +# define int_retval lrv_v0
> +#elif defined __mips__ && _MIPS_SIM == _ABIN32
> +# define pltenter la_mips_n32_gnu_pltenter
> +# define pltexit la_mips_n32_gnu_pltexit
> +# define La_regs La_mips_64_regs
> +# define La_retval La_mips_64_retval
> +# define int_retval lrv_v0
> +#elif defined __mips__ && _MIPS_SIM == _ABIN64
> +# define pltenter la_mips_n64_gnu_pltenter
> +# define pltexit la_mips_n64_gnu_pltexit
> +# define La_regs La_mips_64_regs
> +# define La_retval La_mips_64_retval
> +# define int_retval lrv_v0
> #else
> # error "architecture specific code needed"
> #endif
AFAIK the agreed rule is to use _MIPS_SIM_ABI32, _MIPS_SIM_NABI32 and
_MIPS_SIM_ABI64 respectively.
And checking what's going on I've discovered, to my surprise, the
_ABIO32, _ABIN32 and _ABIN64 macros are still used. Apparently an
incorrect patch was applied under the following ChangeLog entry:
2004-11-05 Maciej W. Rozycki <macro@mips.com>
See the thread starting at:
http://sources.redhat.com/ml/libc-alpha/2004-11/msg00034.html for details
and: http://sources.redhat.com/ml/libc-alpha/2004-11/msg00083.html for the
final patch.
I've prepared a fix reverting the bad change and applying the intended
one that I will send separately once testing concludes. It's a pity it
wasn't spotted before 2.3.4 was released.
Maciej