This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Small fix for misc/sys/syslog.h
- From: Roland McGrath <roland at redhat dot com>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: GOTO Masanori <gotom at debian dot or dot jp>, libc-alpha at sources dot redhat dot com
- Date: Mon, 14 Feb 2005 15:24:06 -0800
- Subject: Re: [PATCH] Small fix for misc/sys/syslog.h
> Roland McGrath wrote:
> > The type is only used for the constant table, and the pointers always point
> > to string constants. const is appropriate.
>
> Yes, it's appropriate when creating the interface from scratch. But it
> might cause problems compiling programs, even breaking the compilation
> if -Werror is used.
You really think #define SYSLOG_NAMES is used by more than one or two things?
I won't make this change on the stable branch, but it seems fine for the trunk.