This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Small fix for misc/sys/syslog.h
- From: GOTO Masanori <gotom at debian dot or dot jp>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: Roland McGrath <roland at redhat dot com>,GOTO Masanori <gotom at debian dot or dot jp>, libc-alpha at sources dot redhat dot com
- Date: Tue, 15 Feb 2005 09:29:07 +0900
- Subject: Re: [PATCH] Small fix for misc/sys/syslog.h
- References: <200502142324.j1ENO6gS009347@magilla.sf.frob.com><4211398C.804@redhat.com>
At Mon, 14 Feb 2005 15:51:40 -0800,
Ulrich Drepper wrote:
> Roland McGrath wrote:
> > You really think #define SYSLOG_NAMES is used by more than one or two things?
> > I won't make this change on the stable branch, but it seems fine for the trunk.
>
> For exactly the same reason it is not worth the trouble.
It's sure "some BSD did it" does not make sense. Including syslog.h
warns "discarding qualifiers" with gcc -Wwrite-strings option (I
confirmed with gcc 2.95). I also think changing const is appropriate
as Roland said.
Regards,
-- gotom