This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix loops in string/strxfrm_l.c


On Sat, May 28, 2005 at 03:32:57PM -0700, Ulrich Drepper wrote:
> Denis Barbier wrote:
> > backw is of type size_t, thus loops
> >   for (backw = idxcnt - 1; backw >= backw_stop; --backw)
> > have trouble if idxcnt or backw_stop is 0.
> 
> Where's the test case?  If you cannot provide one there the patch won't
> be looked at.

As explained in BZ 645, only the last order_start declaration is taken
into account by localedef, so this loop is currently never executed
because there is no forward/backward switch.
Segfaults will occur when localedef is fixed, but I cannot provide
relevant test cases before that.

Previous patch only shifts indices by 1 to make sure that the break test
works as expected if backw_stop is 0.

Denis

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]