This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] #undef __GLIBC__


On Tue, Nov 15, 2005 at 11:38:39AM +0100, Robert Millan wrote:
> On Tue, Nov 15, 2005 at 10:56:03AM +0100, Jakub Jelinek wrote:
> > On Tue, Nov 15, 2005 at 10:44:37AM +0100, Robert Millan wrote:
> > > On GNU/kFreeBSD, __GLIBC__ is a pre-processor macro.  This patch fixes
> > > features.h to #undef it before re-defining it to its proper value.
> > > 
> > > 2005-11-15  Robert Millan  <robertmh@gnu.org>
> > > 
> > >         * include/features.h: #undef __GLIBC__ before #define.
> > 
> > That's IMNSHO the wrong fix.  You should change GCC, so that it doesn't
> > define __GLIBC__ as a preprocessor macro
> 
> We added this to GCC on purpose, because otherwise there's no way to identify
> Glibc.

whats wrong with just letting glibc define it ?  we let features.h
define __GLIBC__ for us in uClibc systems rather than mucking around in
in gcc and we have yet to hit a spot where this didnt work
-mike


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]