This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- From: Benjamin Herrenschmidt <benh at kernel dot crashing dot org>
- To: Fabio Massimo Di Nitto <fabbione at ubuntu dot com>
- Cc: "Ryan S. Arnold" <rsa at us dot ibm dot com>, libc-alpha at sourceware dot org, Ben Collins <ben dot collins at ubuntu dot com>, Jeff Bailey <jbailey at ubuntu dot com>, Paul Mackerras <paulus at samba dot org>, Steve Munroe <sjmunroe at us dot ibm dot com>
- Date: Thu, 02 Nov 2006 17:37:52 +1100
- Subject: Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- References: <1162426488.28331.0.camel@ryanarn-desktop> <1162427296.25682.497.camel@localhost.localdomain> <45498824.2050808@ubuntu.com>
On Thu, 2006-11-02 at 06:54 +0100, Fabio Massimo Di Nitto wrote:
> Benjamin Herrenschmidt wrote:
> > On Wed, 2006-11-01 at 18:14 -0600, Ryan S. Arnold wrote:
> >> I've been sitting on this patch for way too long.
> >>
> >> The TID implementation in the default lowlevelrobustlock.sym is wrong
> >> for PowerPC. The thread point on PowerPC is biased by -0x7000 to extend
> >> the size of the FAST TLS to 64KB. This patch provides a powerpc
> >> implementation to take this into account.
> >
> > Fabio, Jeff: That should fix the root cause of the errors on 2.6.18 and
> > later for which my patch corrected the kernel oops (you would still have
> > gotten an error from the syscall due to that glibc problem).
> >
> > Ben.
> >
>
> Perfect. I will apply in the next upload.
Ryan, I might have done something wrong with my rebuild of the glibc-2.5
(it might not have taken into account the new file, I really don't
understand glibc build system), but I'm still getting the alignment
error...
I'm very busy with a lot of other things, so it's not easy for me do
those tests especially considering how uncomfortable I am workin with
glibc :) I'll try a fresh build from clean sources tomorrow and will see
what's going on.
Ben.