This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "Ryan S. Arnold" <rsa at us dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, Benjamin Herrenschmidt <benh at kernel dot crashing dot org>, Ben Collins <ben dot collins at ubuntu dot com>, Fabio Massimo Di Nitto <fabbione at ubuntu dot com>, Jeff Bailey <jbailey at ubuntu dot com>, Paul Mackerras <paulus at samba dot org>, Steve Munroe <sjmunroe at us dot ibm dot com>
- Date: Thu, 2 Nov 2006 14:13:56 +0100
- Subject: Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- References: <1162426488.28331.0.camel@ryanarn-desktop>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 01, 2006 at 06:14:48PM -0600, Ryan S. Arnold wrote:
> I've been sitting on this patch for way too long.
>
> The TID implementation in the default lowlevelrobustlock.sym is wrong
> for PowerPC. The thread point on PowerPC is biased by -0x7000 to extend
> the size of the FAST TLS to 64KB. This patch provides a powerpc
> implementation to take this into account.
2006-11-01 Ryan S. Arnold <rsa@us.ibm.com>
* sysdeps/unix/sysv/linux/powerpc/lowlevelrobustlock.sym: New file.
Powerpc thread pointer bias requires separate implementation of TID
for powerpc.
Can you explain how this patch can change a single bit in the powerpc libraries?
lowlevelrobustlock.sym is the source for glibc buildtime generated
lowlevelrobustlock.h header.
This header is used in exactly 3 files in glibc sources:
nptl/sysdeps/unix/sysv/linux/sh/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
nptl/sysdeps/unix/sysv/linux/x86_64/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
as the directories clearly suggest, these have nothing to do with powerpc.
Uli, as TID is defined in tcb-offsets.{sym,h}, I think we should just nuke
lowlevelrobustlock.sym and s/<lowlevelrobustlock.h>/<tcb-offsets.h>/
in those 3 files.
Jakub