This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: libc/stdio-common vfprintf.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: Ulrich Drepper <drepper at redhat dot com>, libc-alpha at sources dot redhat dot com
- Date: Fri, 4 May 2007 12:10:19 +0200
- Subject: Re: libc/stdio-common vfprintf.c
- References: <20070502081551.24947.qmail@sourceware.org> <463AFCD2.1030105@aurel32.net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, May 04, 2007 at 11:28:50AM +0200, Aurelien Jarno wrote:
> drepper@sourceware.org a écrit :
> > CVSROOT: /cvs/glibc
> > Module name: libc
> > Changes by: drepper@sourceware.org 2007-05-02 08:15:51
> >
> > Modified files:
> > stdio-common : vfprintf.c
> >
> > Log message:
> > (process_string_arg): Use a VLA rather than fixed length array for ignore.
> >
> > Patches:
> > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdio-common/vfprintf.c.diff?cvsroot=glibc&r1=1.136&r2=1.137
> >
>
> This patch is probably wrong as __mbsnrtowcs still uses the fixed size
> 1024. I guess it should use ignore_size instead.
That was in my original patch too.
But most probably it doesn't matter, at least as long as for no locale
one source char produces more than one wchar_t.
Jakub