This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390: Fix 32/64 bit utmp compat problem v4


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Krebbel wrote:
> + /* Convert the 64 bit struct utmp value in FROM to the 32 bit version
> +    returned in TO.  */
> + static inline void
> + __utmp_convert64to32 (__const struct utmp *from, struct utmp32 *to)

In sources files (as opposed to installed headers) it's const, not __const.


> + int
> + __getutent_r32 (struct utmp32 *__buffer, struct utmp32 **__result)

Even worse here: never use __ prefixes in sources, only in installed
headers and macros where names might conflict.

> + {
> +   struct utmp out64, *out64p;

Don't define more than one variable per line.

- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiDddUACgkQ2ijCOnn/RHTqZACgq83k7pvehruT22o43jL8f/A7
Kq8AnA1fIy0/fe9olq2cE6NVTdFFouHG
=ysah
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]