This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390: Fix 32/64 bit utmp compat problem v4
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: schwidefsky at de dot ibm dot com, libc-alpha at sourceware dot org
- Date: Sun, 20 Jul 2008 10:28:53 -0700
- Subject: Re: [PATCH] S/390: Fix 32/64 bit utmp compat problem v4
- References: <20080529145020.GA32600@homer.boeblingen.de.ibm.com> <48735F88.50209@redhat.com> <20080709102448.GA5565@homer.boeblingen.de.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Krebbel wrote:
> + /* Convert the 64 bit struct utmp value in FROM to the 32 bit version
> + returned in TO. */
> + static inline void
> + __utmp_convert64to32 (__const struct utmp *from, struct utmp32 *to)
In sources files (as opposed to installed headers) it's const, not __const.
> + int
> + __getutent_r32 (struct utmp32 *__buffer, struct utmp32 **__result)
Even worse here: never use __ prefixes in sources, only in installed
headers and macros where names might conflict.
> + {
> + struct utmp out64, *out64p;
Don't define more than one variable per line.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiDddUACgkQ2ijCOnn/RHTqZACgq83k7pvehruT22o43jL8f/A7
Kq8AnA1fIy0/fe9olq2cE6NVTdFFouHG
=ysah
-----END PGP SIGNATURE-----