This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] make check failure patch and a typo clean up.
- From: "Ryan S. Arnold" <rsa at us dot ibm dot com>
- To: GNU libc devel <libc-alpha at sources dot redhat dot com>
- Cc: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
- Date: Wed, 20 Aug 2008 17:21:01 -0500
- Subject: [PATCH] make check failure patch and a typo clean up.
- Reply-to: rsa at us dot ibm dot com
While cleaning up make check we ran across a few issues
for which we've provided the following patches.
1.) Patch 1 prevents an infrequent make check failure
caused by two runs of make check stomping on each other's
temp file usage.
2.) Patch 2 fixes a typo on an internal symbol name.
Regards,
Ryan S. Arnold
IBM Linux Technology Center
Linux Toolchain Development
2008-08-18 Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
* posix/globtest.sh: Create a random tempdir so simultaneous
make check runs don't fail.
Index: libc/posix/globtest.sh
===================================================================
--- libc.orig/posix/globtest.sh
+++ libc/posix/globtest.sh
@@ -26,10 +26,11 @@ export LC_ALL
LANG=C
export LANG
-# Create the arena
-: ${TMPDIR=/tmp}
-testdir=$TMPDIR/globtest-dir
-testout=$TMPDIR/globtest-out
+# Create the arena - We use a random temp directory name so
+# that two or more simultaneous 'make check' runs don't fail.
+: ${TMPDIR=/tmp/$RANDOM}
+testdir=$TMPDIR.globtest-dir
+testout=$TMPDIR.globtest-out
trap 'chmod 777 $testdir/noread; rm -fr $testdir $testout' 1 2 3 15
---
2008-08-20 Ryan S. Arnold <rsa@us.ibm.com>
* sysdeps/powerpc/elf/rtld-global-offsets.sym
(rtdl_global_ro_offsetof): Correct spelling to rtld_global_ro_offset.
--- glibc/sysdeps/powerpc/elf/rtld-global-offsets.sym 2008-08-20 11:49:19.000000000 -0500
+++ glibc.new/sysdeps/powerpc/elf/rtld-global-offsets.sym 2008-08-19 17:46:39.000000000 -0500
@@ -2,6 +2,6 @@
#include <ldsodefs.h>
-#define rtdl_global_ro_offsetof(mem) offsetof (struct rtld_global_ro, mem)
+#define rtld_global_ro_offsetof(mem) offsetof (struct rtld_global_ro, mem)
-RTLD_GLOBAL_RO_DL_HWCAP_OFFSET rtdl_global_ro_offsetof (_dl_hwcap)
+RTLD_GLOBAL_RO_DL_HWCAP_OFFSET rtld_global_ro_offsetof (_dl_hwcap)