This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] make check failure patch and a typo clean up.
- From: "Ryan S. Arnold" <rsa at us dot ibm dot com>
- To: "Carlos O'Donell" <carlos at systemhalted dot org>
- Cc: GNU libc devel <libc-alpha at sources dot redhat dot com>, Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
- Date: Thu, 21 Aug 2008 12:44:50 -0500
- Subject: Re: [PATCH] make check failure patch and a typo clean up.
- References: <1219270861.8790.27.camel@localhost> <119aab440808210906s468902a3y28d977d864d35494@mail.gmail.com>
- Reply-to: rsa at us dot ibm dot com
On Thu, 2008-08-21 at 12:06 -0400, Carlos O'Donell wrote:
> > 1.) Patch 1 prevents an infrequent make check failure
> > caused by two runs of make check stomping on each other's
> > temp file usage.
>
> Wouldn't one or more simultaneous `make check' runs write to the same
> test output file?
>
> Please explain.
The bash shell's $RANDOM env variable is used to provide a random /tmp/
directory name per run of make check. $RANDOM is reserved by bash and
provides a pseudo-random number.
> > 2.) Patch 2 fixes a typo on an internal symbol name.
>
> This cleanup patch looks fine to me. It's only a typo in the name of
> the macro, but the typo'd name is used consistently.
The 'rltd_global_ro_offset' macro is only used in this sym file. The
RTLD_GLOBAL_RO_DL_HWCAP_OFFSET macro is used elsewhere.
> In the future you should really send the patches as separate emails.
> Sending them in a single email makes me think they are somehow
> related.
Okay.
Regards,
Ryan