Re: [PATCH] S/390: HW accelerated iconv module for iso-8859-1/cp37conversions

[Ulrich Drepper <drepper at redhat dot com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Krebbel wrote:
> Daniel Appich did comprehensive performance analysis in his diploma
> thesis and measured that the conversion is accelerated by up to 40
> times!

40 times faster if it isn't used at all/much doesn't amount to much.
But so be it.


> Trying to build the iconv module from the s390 sysdep directory turned
> out to be rather tricky (at least for me not being familiar with the
> libc build machinery). After experimenting with several makefile
> variables I've ended up trying to mimic as much as necessary from the
> iconvdata Makefile until the module got built.

You should add the rules to the sysdeps/s390/s390x/Makefile.  Don't
define all these variables which might clash.  Don't  indent variable
definitinos.


> The current Makefile installs the new module into lib/gconv/s390x and
> generates a gconv-modules file which is installed into the very same
> dir.  The modules therefore will not be used until the path of the
> directory is appended to GCONV_PATH.

You should add the module in the regular gconv directory.  To add the
rules to gconv-modules add a rule to your Makefile which depends on the
gconv-modules file being copied into the compile directory, then you
check whether the new entry has been added and if not, add it.

- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknbnTYACgkQ2ijCOnn/RHRXNQCbB9K/p/cNS2y4ZJj4ss2SKyJG
eEgAoKe3wg14jX6rRsXl5qNV/2SD3fE0
=mYOf
-----END PGP SIGNATURE-----