This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Support multiarch for i686
- From: Ulrich Drepper <drepper at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 30 Jul 2009 22:05:14 -0700
- Subject: Re: PATCH: Support multiarch for i686
- References: <20090730213311.GA15372@lucon.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
H.J. Lu wrote:
> +#ifdef __x86_64__
Don't do that. Define a macro in the i386 version saying this info
isn't wanted and then test it here. Correct all the places where you
use this type of #ifdef.
> @@ -530,9 +522,7 @@ init_cacheinfo (void)
> /* Query until desired cache level is enumerated. */
> do
> {
> - asm volatile ("cpuid"
> - : "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx)
> - : "0" (4), "2" (i++));
> + __cpuid_count (4, i++, eax, ebx, ecx, edx);
__cpuid_count is a bit too recent. Not even gcc 4.3 has it.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkpye4oACgkQ2ijCOnn/RHTw2QCfSZDMbDlywdP39v6iSgX20bLz
G1wAoKLDQnbaj+NhBcALpNRVB+lVOxkr
=ga+d
-----END PGP SIGNATURE-----