This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Update unwind info in memcmp-ssse3.S
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 16 Feb 2010 13:08:49 -0800
- Subject: Re: PATCH: Update unwind info in memcmp-ssse3.S
- References: <20100216190638.GA5534@lucon.org> <4B7AFAF4.6020500@redhat.com>
On Tue, Feb 16, 2010 at 12:07 PM, Ulrich Drepper <drepper@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 02/16/2010 11:06 AM, H.J. Lu wrote:
>
>
>> + ? ? CFI_POP (%ebx)
>
> This pop might be missing, I'll have to check but
>
>
>
>> - ? ? cfi_restore_state
>> - ? ? cfi_remember_state
>> + ? ? CFI_PUSH (%esi)
>> + ? ? CFI_PUSH (%edi)
>
> ... that nonsense. ?The result should be the same just your's is twice
> as long.
>
I just submitted the diff against my version, which is known to work
correctly. I will update it again after the real bug is fixed.
Thanks.
--
H.J.