This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Don't set ELFOSABI_LINUX in dynamic ifunc-using executable
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: binutils at sourceware dot org, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 18 Feb 2010 17:20:07 -0800
- Subject: Re: PATCH: Don't set ELFOSABI_LINUX in dynamic ifunc-using executable
- References: <20100218224138.GA16300@intel.com> <20100219010300.GF9546@bubble.grove.modra.org>
On Thu, Feb 18, 2010 at 5:03 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Feb 18, 2010 at 02:41:38PM -0800, H.J. Lu wrote:
>> ? ? ? * elf32-i386.c (elf_i386_add_symbol_hook): Don't set
>> ? ? ? has_ifunc_symbols if the symbol comes from a shared library.
>> ? ? ? * elf32-ppc.c (ppc_elf_add_symbol_hook): Likewise.
>> ? ? ? * elf32-sparc.c (elf32_sparc_add_symbol_hook): Likewise.
>> ? ? ? * elf64-ppc.c (ppc64_elf_add_symbol_hook): Likewise.
>> ? ? ? * elf64-sparc.c (elf64_sparc_add_symbol_hook): Likewise.
>> ? ? ? * elf64-x86-64.c (elf64_x86_64_add_symbol_hook): Likewise.
>>
>> ? ? ? * ld-ifunc/ifunc.exp: Expect System V OSABI in dynamic
>> ? ? ? ifunc-using executable.
>
> OK if you have checked with the glibc people that this is the right
> thing to do. ?(It seems like it would be to me.)
>
Hi,
I like to apply this linker patch:
http://sourceware.org/ml/binutils/2010-02/msg00369.html
which sets ELFOSABI_LINUX only when we see an IFUNC symbol
from .o file. Linker already treats IFUNC symbols from DSO as
normal FUNC symbols. Does anyone see any problems.
Thanks.
--
H.J.