This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use IFUNC on x86-64 memset
- From: Ulrich Drepper <drepper at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 5 Nov 2010 21:02:43 -0400
- Subject: Re: PATCH: Use IFUNC on x86-64 memset
- References: <20101105231035.GA20552@intel.com>
On Fri, Nov 5, 2010 at 19:10, H.J. Lu <hongjiu.lu@intel.com> wrote:
> + Â Â Â/* Intel processors prefers SSE instructions for memory/string
> + Â Â Â Âroutines if they are avaiable. Â*/
> + Â Â Â__cpu_features.feature[index_Prefer_SSE] |= bit_Prefer_SSE;
In general OK but I don't like the name of the bit. There might be
later conflicting decisions, i.e., maybe sometimes SSE is not
preferred. Then the macro name s misleading.
The comment you have here already says it better. Use
_Prefer_SSE_for_memop or something of that kind.