This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add support fedisableexcept, feenableexcept,fegetexcept and feupdateenv for Renesas sh4
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: iwamatsu at nigauri dot org
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 24 May 2011 23:19:21 +0900 (JST)
- Subject: Re: [PATCH 1/2] Add support fedisableexcept, feenableexcept,fegetexcept and feupdateenv for Renesas sh4
- References: <1306214766-25971-1-git-send-email-iwamatsu@nigauri.org>
Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> 2011-05-23 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> * sysdeps/sh/sh4/fpu/fedisblxcpt.c:
> Add support fedisableexcept for Renesas sh4.
> * sysdeps/sh/sh4/fpu/feenablxcpt.c:
> Add support feenableexcept for Renesas sh4.
> * sysdeps/sh/sh4/fpu/fegetexcept.c:
> Add support fegetexcept for Renesas sh4.
> * sysdeps/sh/sh4/fpu/feupdateenv.c:
> Add support feupdateenv for Renesas sh4.
Use the usual style like as other ChangeLog entries:
* sysdeps/sh/sh4/fpu/fedisblxcpt.c: New file.
* sysdeps/sh/sh4/fpu/feenablxcpt.c: New file.
...
and don't send the diff file for ChangeLog.
Other part of the patch looks OK to me, though I guess
your patches require copyright assignment. Do you have
FSF copyright assignment?
Regards,
kaz