This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Rewrite fraiseexcpt for Renesas sh4
Hi,
Thanks for your review.
2011/5/24 Kaz Kojima <kkojima@rr.iij4u.or.jp>:
> Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
>> 2011-05-24 ?Nobuhiro Iwamatsu ?<iwamatsu@nigauri.org>
>>
>> ? ? ? * sysdeps/sh/sh4/fpu/fraiseexcpt.c:
>> ? ? ? Rewrite fraiseexcpt for Renesas sh4. The exception does not occur
>> ? ? ? only by having validated the bit of the fpu exception.
>> ? ? ? It is necessary for us to produce an exception using FPU order
>> ? ? ? intentionally.
>
> Again ChangeLog entry should be something like
>
> ? ? ? ?* sysdeps/sh/sh4/fpu/fraiseexcpt.c (feraiseexcept): Produce
> ? ? ? ?an exception using FPU order intentionally.
>
> and remove the diff against ChangeLog from the patch.
> The comment like
>
>>+ ?/* inexact ?*/
>>+ ?if (excepts & FE_INEXACT)
>
> looks unnecessary. ?Also there are several indentation issues
> in the patch.
>
OK, I will send fixed patch with other.
Best regards,
Nobuhiro
> Regards,
> ? ? ? ?kaz
>
--
Nobuhiro Iwamatsu
?? iwamatsu at {nigauri.org / debian.org}
?? GPG ID: 40AD1FA6