This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Urlich, I fixed overflow bug in 32 bit patch. I've attached small fix that should be applied after strcat_32 patch. I added some tests to string/strncat.c for checking overflow bugs as well. But I have one extra fail on both Core i7 (uses strcat-sse.S) and Core2 (uses strcat-ssse3.S). make[4]: *** [/msticlxl27_users/ldmitrie/glibc_32_build/build-i686-linux/string/inl-tester.out] Error 1 make[3]: *** [string/xtests] Error 2 But I checked master branch for 32 bit (without my 32 bit strcat/strncat). I have the same problem on both core i7 and core 2 machines. It seems that there is a problem in the test, not in strncat. Problem regarding with srncat test. I can run "./build-i686-linux/string/inl-tester" on my machine with glibc 2.13 and have the same as for built glibc. ... strncat flunked test 14 n1=7, n2=8, n3=6, n4=12, buf1=62,62,62,62,62,62,62,62,61,61,61,61,61,61,00,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62 strncat flunked test 14 n1=7, n2=8, n3=6, n4=13, buf1=62,62,62,62,62,62,62,62,61,61,61,61,61,61,00,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62 strncat flunked test 14 n1=7, n2=8, n3=6, n4=14, buf1=62,62,62,62,62,62,62,62,61,61,61,61,61,61,00,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62,62 ... -- Liubov
Attachment:
ChangeLog.strncat_32_bit_fix
Description: Binary data
Attachment:
strncat_32_bit_fix.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |