Re: Missing includes

[Andreas Jaeger <aj at suse dot com>]

On Sunday, October 23, 2011 10:33:09 PM Ulrich Drepper wrote:
> On Tue, Oct 18, 2011 at 06:02, Andreas Jaeger <aj@suse.com> wrote:
> > Compiling current glibc on x86, I saw these warnings:
> > 
> > nss_db/db-initgroups.c: In function '_nss_db_initgroups_dyn':
> > nss_db/db-initgroups.c:60:3: warning: implicit declaration of function
> > 'strlen' [-Wimplicit-function-declaration]
> 
> I don't see these.

Here's my compile line - with GCC 4.6:
gcc nss_db/db-init.c -c -std=gnu99 -fgnu89-inline -D_FORTIFY_SOURCE=2 -O2 -U_FORTIFY_SOURCE -Wall -Winline -Wwrite-
strings -fasynchronous-unwind-tables -fmerge-all-constants -fmessage-length=0 -funwind-tables -g -mno-tls-direct-seg-refs -
Wstrict-prototypes  -fomit-frame-pointer -fPIC      -I../include -I/home/abuild/rpmbuild/BUILD/glibc-2.14.90/cc-base/nss -
I/home/abuild/rpmbuild/BUILD/glibc-2.14.90/cc-base -I../sysdeps/i386/elf -I../nptl/sysdeps/unix/sysv/linux/i386/i586 -
I../nptl/sysdeps/unix/sysv/linux/i386 -I../sysdeps/unix/sysv/linux/i386 -I../nptl/sysdeps/unix/sysv/linux -I../nptl/sysdeps/pthread -
I../sysdeps/pthread -I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common -I../sysdeps/unix/mman -
I../sysdeps/unix/inet -I../sysdeps/unix/sysv/i386 -I../nptl/sysdeps/unix/sysv -I../sysdeps/unix/sysv -I../sysdeps/unix/i386 -
I../nptl/sysdeps/unix -I../sysdeps/unix -I../sysdeps/posix -I../nptl/sysdeps/i386/i586 -I../sysdeps/i386/i586 -I../sysdeps/i386/i486 -
I../nptl/sysdeps/i386/i486 -I../sysdeps/i386/fpu -I../nptl/sysdeps/i386 -I../sysdeps/i386 -I../sysdeps/wordsize-32 -
I../sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic/elf -
I../sysdeps/generic -I../nptl  -I.. -I../libio -I.  -D_LIBC_REENTRANT -DNO_TLS_DIRECT_SEG_REFS -include ../include/libc-symbols.h  
-DPIC -DSHARED -DNOT_IN_libc=1 -DIS_IN_libnss_db=1    -o /home/abuild/rpmbuild/BUILD/glibc-2.14.90/cc-base/nss/db-init.os -
MD -MP -MF /home/abuild/rpmbuild/BUILD/glibc-2.14.90/cc-base/nss/db-init.os.dt -MT 
/home/abuild/rpmbuild/BUILD/glibc-2.14.90/cc-base/nss/db-init.os
nss_db/db-init.c: In function '_nss_db_init':
nss_db/db-init.c:46:3: warning: implicit declaration of function 'strcpy' [-Wimplicit-function-declaration]
nss_db/db-init.c:46:3: warning: incompatible implicit declaration of built-in function 'strcpy' [enabled by default]

 
> > In file included from ../nptl/sysdeps/i386/tls.h:29:0,
> >                 from ../sysdeps/i386/i486/bits/atomic.h:21,
> >                 from ../include/atomic.h:51,
> >                 from ../nscd/nscd-client.h:30,
> >                 from ../nscd/nscd.h:31,
> >                 from nss_db/db-init.c:21:
> > ../nptl/sysdeps/pthread/list.h: In function 'list_add':
> > ../nptl/sysdeps/pthread/list.h:64:3: warning: implicit declaration of
> > function 'atomic_write_barrier ' [-Wimplicit-function-declaration]
> 
> This is fixed now.

Thanks,
Andreas

-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126