This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 9/10] Tilera (and Linux asm-generic) support for glibc
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Chris Metcalf <cmetcalf at tilera dot com>
- Cc: libc-alpha at sourceware dot org, Arnd Bergmann <arnd at arndb dot de>, Linas Vepstas <linas at codeaurora dot org>, Guan Xuetao <gxt at mprc dot pku dot edu dot cn>, Jonas Bonn <jonas at southpole dot se>, Chen Liqin <liqin dot chen at gmail dot com>
- Date: Fri, 11 Nov 2011 10:09:05 -0800 (PST)
- Subject: Re: [PATCH v2 9/10] Tilera (and Linux asm-generic) support for glibc
- References: <201111100054.pAA0sf6u025585@farm-0002.internal.tilera.com><201111100056.pAA0uKcv025809@farm-0002.internal.tilera.com>
> 2011-11-09 Chris Metcalf <cmetcalf@tilera.com>
>
> * bits/byteswap.h (__bswap*): Use __builtin_bswap for gcc 4.3 and
> above. Improves code generation for gcc 4.3 and 4.4 compilers
> without bswap pattern detection.
ChangeLog indentation is wrong. Don't use * or other such
abbreviations--list all the macros you touched by name.
This seems reasonable if some GCC folks can confirm that 4.3 and later
produce optimal code for __builtin_bswap{32,64} on all machines.
Thanks,
Roland