This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch] Another fix for cycle detection


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


The "seen" counter in the cycle detection code is defined as a char
array.  As a result the counter can trivially overflow during cycle
detection when presented with 127 or more libraries in a pathological
ordering.

While it seems somewhat absurd, I expect we're not far from the point
where we're going to see in excess of 256 DSOs being used.  So simply
changing to an unsigned char isn't really sufficient.

It also seems that using a 32 or 64 bit type would be horribly
excessive.  So, an "unsigned short" seems to be the right compromise
to me.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPHdNAAAoJEBRtltQi2kC7/HYH/026ZULDl//WXl+MA1+vSxJ8
Fr/smqmHME1rExO7I9mu6ZkvfFTZC8bMaqx66RNASeZpsbYOt8NUqEBuGyg7oBZH
2uZPUE89eoADT0WyNlZ4Xh8Xl/t7OsqOT4xS7cCKBGhUwToM/6STw75lpadt9Tlp
wEAvUgvVDkiwmXL1WkgBnVt9eAx+zesEIH/h2TYiZs0rGTWVZJ+I2jRKYXyGQjav
RzYC8uGPzhWpkEKpY5Iahkzsw2JudGL9JjA3GRX7atCrAGFiMVRzUnh82kyGNAeU
RFfz5dZfxsPcb8y9licSWdFvnAGX2/P9dLmizuxTt5ZwqRcco2s8XWv/NktWmMs=
=IWGF
-----END PGP SIGNATURE-----

Attachment: P
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]