This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Another fix for cycle detection
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/23/12 14:47, Roland McGrath wrote:
> I think it's clearer to use a type like uint16_t.
That'd be fine with me...
> If overflow is a concern, then there should be an explicit overflow
> check. How about starting out with uint8_t and overflow checking?
I've already seen it overflow 8 bit signed, seems silly to flip to an
unsigned which doesn't give us that much headroom. But if that's what
you'd prefer, I'll do it.
In case it's not obvious, this patch is pointless without last week's
fix to cycle detection:
http://sources.redhat.com/ml/libc-alpha/2012-01/msg00072.html
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPHdcPAAoJEBRtltQi2kC7l+oH/3eji/41JjIdGH3GkLoNmw9C
Y7GsPnb7KsWbr2Dq94yZlHl0kkcrd0/AnPMxBRKZYM0cLSs8ZcIT3PMCtNqikKXS
FF/Cn6cpyyLvh1oqJhS2rttagPMu14Zs0hK70FEhm+qC6BZzu0C1Bei2/SqHSzda
4MBBoF+w/M8nspHo7Yint4Otwi1fDD6BfRgEOiDGc3v3y066yQT4c0HKVjqyJOr0
cn8Ns6LLbcwHZow50xtweev3fra3ORatzH9aruAk05c/CpVx/fPpIuWECu5ltFKc
ie9Efc9ASQRBkUmuof1pnHfsu+EcJ30U8DKE+dhbdVaDPo8C6LLUGIjKYMFx0rI=
=MDgR
-----END PGP SIGNATURE-----