This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [tile] Mark epoll_pwait as hidden
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, <libc-alpha at sourceware dot org>
- Date: Thu, 26 Jan 2012 11:40:50 -0500
- Subject: Re: [tile] Mark epoll_pwait as hidden
- References: <201111100054.pAA0sf6u025585@farm-0002.internal.tilera.com> <201111100056.pAA0uEg2025798@farm-0002.internal.tilera.com> <20111111175741.4B3282C0F9@topped-with-meat.com> <201201252127.q0PLRkX7027119@farm-0002.internal.tilera.com> <Pine.LNX.4.64.1201252329520.30958@digraph.polyomino.org.uk>
On 1/25/2012 6:32 PM, Joseph S. Myers wrote:
> On Wed, 25 Jan 2012, Chris Metcalf wrote:
>
>> diff --git a/sysdeps/unix/sysv/linux/epoll_pwait.c b/sysdeps/unix/sysv/linux/epoll_pwait.c
>> index e689073..9f72d18 100644
>> --- a/sysdeps/unix/sysv/linux/epoll_pwait.c
>> +++ b/sysdeps/unix/sysv/linux/epoll_pwait.c
>> @@ -1,4 +1,4 @@
>> -/* Copyright (C) 2007 Free Software Foundation, Inc.
>> +/* Copyright (C) 2007, 2011 Free Software Foundation, Inc.
>> This file is part of the GNU C Library.
>>
>> The GNU C Library is free software; you can redistribute it and/or
>> @@ -24,6 +24,8 @@
>> #include <sysdep-cancel.h>
>> #include <sys/syscall.h>
>>
>> +libc_hidden_proto (epoll_pwait)
> Typically this would go in a header rather than being duplicated both in
> the file defining the function and the file using it. That is, you'd have
> include/sys/epoll.h, like include/sys/prctl.h, that includes the main
> header with #include_next and then has the libc_hidden_proto.
Sounds good. Here's the revised change. I'll make the obvious change to
the generic libc-ports file (removing the now-unnecessary
libc_hidden_proto) after this is taken.
2012-01-26 Chris Metcalf <cmetcalf@tilera.com>
* include/sys/epoll.h: New file.
* sysdeps/unix/sysv/linux/epoll_pwait.c (epoll_pwait): Add
libc_hidden_def.
diff --git a/include/sys/epoll.h b/include/sys/epoll.h
new file mode 100644
index 0000000..ce1c2e2
--- /dev/null
+++ b/include/sys/epoll.h
@@ -0,0 +1,6 @@
+#ifndef _SYS_EPOLL_H
+#include_next <sys/epoll.h>
+
+libc_hidden_proto (epoll_pwait)
+
+#endif
diff --git a/sysdeps/unix/sysv/linux/epoll_pwait.c b/sysdeps/unix/sysv/linux/epoll_pwait.c
index e689073..4f1194a 100644
--- a/sysdeps/unix/sysv/linux/epoll_pwait.c
+++ b/sysdeps/unix/sysv/linux/epoll_pwait.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2007 Free Software Foundation, Inc.
+/* Copyright (C) 2007, 2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -67,3 +67,5 @@ stub_warning (epoll_pwait)
# include <stub-tag.h>
#endif
+
+libc_hidden_def (epoll_pwait)
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com