This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [tile] Mark epoll_pwait as hidden
On Thu, 26 Jan 2012, Chris Metcalf wrote:
> > Typically this would go in a header rather than being duplicated both in
> > the file defining the function and the file using it. That is, you'd have
> > include/sys/epoll.h, like include/sys/prctl.h, that includes the main
> > header with #include_next and then has the libc_hidden_proto.
>
> Sounds good. Here's the revised change. I'll make the obvious change to
> the generic libc-ports file (removing the now-unnecessary
> libc_hidden_proto) after this is taken.
>
> 2012-01-26 Chris Metcalf <cmetcalf@tilera.com>
>
> * include/sys/epoll.h: New file.
> * sysdeps/unix/sysv/linux/epoll_pwait.c (epoll_pwait): Add
> libc_hidden_def.
Thanks, this patch looks good to me; I'd say wait a bit to see if anyone
spots problems or requests a different approach, then commit.
--
Joseph S. Myers
joseph@codesourcery.com