This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix allocation in nss_compat for large number of membershipsto a group

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: libc-alpha at sourceware dot org
Date: Thu, 9 Feb 2012 17:31:04 +0530
Subject: [PATCH] Fix allocation in nss_compat for large number of membershipsto a group

Hi,

nss_compat allocates buffer space on stack using alloca (and
extend_alloca) for initgroup and keeps extending it to fit in larger
lines. This breaks for cases where the number of members in a gorup
are very large, causing the alloca reference to go beyond thread stack
boundary. Attached patch falls back to malloc/free if the buffer size
needed is beyond __libc_alloca_cutoff.

Regards,
Siddhesh


ChangeLog:

2012-02-09  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* nis/nss_compat/compat-initgroups.c (getgrent_next_nss,
	_nss_compat_initgroups_dyn): Fall back to malloc/free for
	large group memberships.

Attachment: glibc-nss-compat.patch
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]