This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add testcase for bug 5794 (incorrect expm1 overflow)
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 29 Feb 2012 12:54:33 -0500
- Subject: Re: Add testcase for bug 5794 (incorrect expm1 overflow)
- Authentication-results: mr.google.com; spf=pass (google.com: domain of patofiero@gmail.com designates 10.236.190.5 as permitted sender) smtp.mail=patofiero@gmail.com; dkim=pass header.i=patofiero@gmail.com
- References: <Pine.LNX.4.64.1202291746470.7156@digraph.polyomino.org.uk>
On Wed, Feb 29, 2012 at 12:47 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> Bug 5794 (incorrect expm1 overflow) was fixed in 2008, but without a
> testcase being added to the testsuite. ?I propose this patch to add
> such a testcase (which I've verified did indeed fail with old glibc).
>
> 2012-02-29 ?Joseph Myers ?<joseph@codesourcery.com>
>
> ? ? ? ?* math/libm-test.inc (expm1_test): Add test for bug 5794.
> ? ? ? ?* sysdeps/i386/fpu/libm-test-ulps: Update.
> ? ? ? ?* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
Add a BZ entry in the ChangeLog instead of in comment?
If we get into the habit of using a BZ entry for all changes related
to the bug then when we turn on the committ<->bugzilla integration
for git we'll get nice updates automatically in the issue.
Otherwise looks OK to me.
Cheers,
Carlos.