This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add testcase for bug 5794 (incorrect expm1 overflow)
On Wed, 29 Feb 2012, Carlos O'Donell wrote:
> On Wed, Feb 29, 2012 at 12:47 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
> > Bug 5794 (incorrect expm1 overflow) was fixed in 2008, but without a
> > testcase being added to the testsuite. ?I propose this patch to add
> > such a testcase (which I've verified did indeed fail with old glibc).
> >
> > 2012-02-29 ?Joseph Myers ?<joseph@codesourcery.com>
> >
> > ? ? ? ?* math/libm-test.inc (expm1_test): Add test for bug 5794.
> > ? ? ? ?* sysdeps/i386/fpu/libm-test-ulps: Update.
> > ? ? ? ?* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
>
> Add a BZ entry in the ChangeLog instead of in comment?
>
> If we get into the habit of using a BZ entry for all changes related
> to the bug then when we turn on the committ<->bugzilla integration
> for git we'll get nice updates automatically in the issue.
>
> Otherwise looks OK to me.
Thanks, I've applied this with the [BZ #5794] added.
Using [BZ #N] for anything related to a bug does make sense - though you
need to be careful not to think someone has forgotten a NEWS entry, and so
make one for them, on the basis of a [BZ #N] entry, given that it may not
be the fix for the bug but a testcase (as here) for a bug previously
fixed, or only a partial fix for a bug whose fix will need several
patches.
--
Joseph S. Myers
joseph@codesourcery.com