This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] BZ#13743: PowerPC - Add a new header for platformspecific functions


On Tue, Mar 6, 2012 at 9:33 AM, Carlos O'Donell <carlos@systemhalted.org> wrote:
> On Tue, Mar 6, 2012 at 8:57 AM, Tulio Magno Quites Machado Filho
> <tuliom@linux.vnet.ibm.com> wrote:
>> Include sys/platform.h for platform specific and non-standard functions.
>>
>> 2012-02-28 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>>
>> Â Â Â Â[BZ #13743]
>> Â Â Â Â* sysdeps/unix/sysv/linux/powerpc/Makefile (sysdep_headers): Include
>> Â Â Â Âsys/platform.h.
>> Â Â Â Â* sysdeps/unix/sysv/linux/powerpc/sys/platform.h: New file.
>
> This patch, along with the followup patch look great
> (http://sourceware.org/ml/libc-alpha/2012-03/msg00114.html).
>
> I'd like to see Roland, Joseph, or Ryan comment on this first before I
> check it in.

This looks good to me too.

> Ryan, Roland, Joseph,
>
> Platform specific macros should live in a new header file e.g. sys/platform.h.
>
> Many other OSs including OS X, BSD, and QNX have a sys/platform.h with
> platform specific helper functions that are installed along with the C
> library.
>
> I understand the need for these low-level functions and that the C
> library is considered a canonical place for things like this (and it
> makes it easy to teach users how to use it e.g. #include
> <sys/platform.h>).
>
> I would like to see sys/platform.h become the place for non-standard
> low-level macros.
>
> Comments?

I'm totally fine with this as the location for platform specific
helper functions and low-level macros.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]