This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Split parts of bits/socket.h to bits/sockettypes.h
On Fri, Mar 9, 2012 at 2:57 AM, Roland McGrath <roland@hack.frob.com> wrote:
> If it's going to contain nothing but enum __socket_type, then I'd prefer
> the name <bits/socket_type.h> (and the comment above the inclusion should
> make it more explicit that enum __socket_type is what it defines).
> sockettypes sounds like something that declares all the (C) types related
> to sockets. ?Also, always make the top comment line of every new file a
> descriptive line rather than being the copyright line.
Making clear what the file contains is always a win.
> Otherwise fine by me, though I think Dave should both agree and test it on
> sparc before it goes in.
I have one more suggestion:
Can we start documenting this stuff piece-by-piece under "Internals
Documentation" in the wiki?
We have a "Porting" section in the manual which could also do with
documentation.
I'd like to get into the habit of writing documentation at the same
time as accepting fixes.
A core C library lives and dies by documentation :-)
Cheers,
Carlos.