This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH [1/n]: Initial x32 support
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 15 Mar 2012 12:40:58 -0700 (PDT)
- Subject: Re: PATCH [1/n]: Initial x32 support
- References: <20120315181727.GB21802@intel.com>
You've got way too much going on here for a single patch.
This needs to be several separate patches. Use Subject:
lines that say something meaningful about the content of
the change, not just a vague high-level one like this.
An individual change in generic code and the individual change in
configuration-specific code that requires it can go together.
Intimately related changes like a configure.in change adding a new
variable, a config.make.in change substituting, and a makefile change using
it, all belong in one ChangeLog paragraph and in one patch together.
Dimly related changes like several different new variables do not.
Thanks,
Roland